Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rtl to theme, use in components #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohofo7
Copy link

@mohofo7 mohofo7 commented Apr 26, 2022

@mohofo7
Copy link
Author

mohofo7 commented Apr 26, 2022

there is only one problem, I can't find a way to fix table in rtl.

any hint about that would be helpful.

@mohofo7
Copy link
Author

mohofo7 commented May 5, 2022

@loreanvictor

@loreanvictor
Copy link
Contributor

@mohofo7 thanks for the PR (and the bump 😅). I've been exceedingly busy with other stuff and since codedoc has been relatively stable (although in dire need of a dependency update to resolve some security issues), haven't had much time for it. Will check your PR asap, thanks again!

As for tables: since your solution involves adding the RTL setting to the theme object, I suspect you can simply modify these styles and make them similarly vary based on whether the theme is RTL or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants