feat: Add Phase 1 React infrastructure for Angular to React migration #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initialize React + TypeScript project with Vite build tool - Configure React Router v6 with all routes from Angular app - Feed routes: /news/:page, /newest/:page, /show/:page, /ask/:page, /jobs/:page - Lazy-loaded routes: /item/:id, /user/:id - Set up PWA support with Vite PWA plugin and Workbox - Configure environment files (.env.development, .env.production) - Match Angular build script patterns (start, build:dev, build:prod) - Create placeholder page components ready for component migration - Add comprehensive README with project structure and Phase 1 checklist This establishes the foundation for Phase 2 component migration. The React project is in react-migration/ subdirectory to run alongside the existing Angular app during the migration process. Co-Authored-By: Gabe Smith <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add Phase 1 React infrastructure for Angular to React migration
Summary
This PR adds the complete React + TypeScript project infrastructure for Phase 1 of the Angular to React migration. The new React project is located in the
react-migration/subdirectory and includes:.env.developmentand.env.productionfiles matching Angular's patternstart,build:dev,build:prod)Feed,ItemDetails, andUserProfilecomponents showing route info (no real functionality yet)The React project runs alongside the existing Angular app during the migration process. No Angular code was modified - this only adds new files in the
react-migration/directory.Review & Testing Checklist for Human
This PR adds ~16k lines of code (mostly pre-configured UI components). The routing setup is critical and needs thorough testing:
cd react-migration && npm install && npm run dev- Verify the app starts without errors/news/1,/newest/1,/show/1,/ask/1,/jobs/1and verify each route renders correctly/item/123and/user/testuserand verify these routes load (check DevTools Network tab for separate chunks)npm run buildand verify:dist/sw.js,dist/workbox-*.js)dist/assets/for separate item/user JS files)npm run devand would show "Production Mode" afternpm run buildreact-migration/the right place for this? Should it be at the repo root or elsewhere?Notes
What's NOT included (expected for Phase 2):
Dependencies:
Session Info: