Phase 2: Implement Core Components and API Integration for React Migration #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… migration - Created new React + TypeScript project with Vite inside angular2-hn repo - Installed and configured React Router with all Angular routes: * Feed routes: /news/:page, /newest/:page, /show/:page, /ask/:page, /jobs/:page * Item details: /item/:id * User profile: /user/:id - Implemented Settings Context API for state management: * Theme management (default/night) with system preference detection * localStorage persistence for all settings (theme, openLinkInNewTab, titleFontSize, listSpacing) * System dark mode preference detection using window.matchMedia - Created placeholder page components (Feed, ItemDetails, User) - Fixed lint error in pre-installed use-toast.ts hook - Tested locally: app runs, routing works, theme switching functional This establishes the foundation for migrating the Angular Hacker News client to React. Co-Authored-By: Gabe Smith <[email protected]>
…ation - Created TypeScript interfaces for Story, User, Comment, PollResult, FeedType - Implemented HackerNewsAPIService with fetchFeed(), fetchItemContent(), fetchUser() methods using fetch API - Created reusable Loader and ErrorMessage components for loading/error states - Updated Feed component to fetch real Hacker News data with pagination (Prev/More links) - Created Item component for feed list items with settings integration (fontSize, spacing, openInNewTab) - Updated ItemDetails component to display item details with nested comments, poll support, HTML content rendering - Created Comment component with collapsible threading functionality ([+/-] buttons) - Updated User component to display user profiles with karma, created date, about section - All components integrate with Settings Context from Phase 1 (theme, settings) - Tested locally: all feed types work (news, newest, show, ask, jobs), pagination works bidirectionally, comment collapsing verified, error handling confirmed - Browser console has no errors during navigation - Lint passes with 0 errors Note: User profile API endpoint (/user/:id) doesn't exist on node-hnapi.herokuapp.com, matching Angular app behavior Co-Authored-By: Gabe Smith <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 2: Implement Core Components and API Integration for React Migration
Summary
This PR implements Phase 2 of the Angular to React migration, building out all core components with real Hacker News API integration. The React app now fetches and displays real data from the Hacker News API with full functionality including feeds, pagination, item details, nested comments with collapsible threading, and user profiles.
Key changes:
HackerNewsAPIServicewithfetchFeed(),fetchItemContent(), andfetchUser()methods using the fetch APIAPI Base URL:
https://node-hnapi.herokuapp.comReview & Testing Checklist for Human
cd react-app && npm install && npm run dev. Verify the app starts at http://localhost:5173 and redirects to /news/1dangerouslySetInnerHTMLin Comment.tsx, ItemDetails.tsx, and User.tsx. Verify the API sanitizes HTML content to prevent XSS attacksNotes
Known Limitation - User Profiles:
The user profile endpoint (
/user/:id) does not exist on the node-hnapi.herokuapp.com API. This was confirmed via curl testing:curl -s https://node-hnapi.herokuapp.com/user/pg # Returns: "Cannot GET /user/pg"This matches the Angular app's behavior - the endpoint is implemented identically but the API doesn't support it. Error handling displays "Could not load user {username}" when this occurs.
Testing Performed:
Browser Screenshots:
Link to Devin run: https://app.devin.ai/sessions/d83e0f9ca9c44669a5a976f8e0ce006e
Requested by: Gabe Smith ([email protected])