Skip to content

Update header to white background with black text #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update header to white background with black text #73

wants to merge 1 commit into from

Conversation

@devin-ai-integration
Copy link

@devin-ai-integration devin-ai-integration bot commented Oct 13, 2025 •
edited
Loading

Update header to white background with black text

Summary

Updated the Angular2-HN application header from colored backgrounds (red for default, dark gray for night, black for amoled) with white text to a white background (#ffffff) with black text (#000) across all three themes, matching the Figma design specifications.

Key changes:

  • Header background → white for all themes (default, night, amoledblack)
  • Header text & navigation links → black
  • Settings icon (cog.svg) → black fill
  • Logo-inner background → subtle gray (#f5f5f5) for visual depth

Review & Testing Checklist for Human

  • Design intent confirmation: Verify that Night and Black AMOLED themes should have white headers (this creates white-on-dark contrast). The Figma design showed a white header, but didn't specify behavior for dark themes.
  • Test all three themes (Default, Night, Black AMOLED) and verify header looks good in each
  • Check header on mobile viewport (different styles apply at mobile breakpoints)
  • Verify logo and settings icon are visible and properly styled in all themes
  • Quick scan for any other pages/views that might be affected by these theme variable changes

Test Plan

  1. Open app in browser
  2. Navigate through different pages (news, newest, show, ask, jobs)
  3. Click settings icon (top right)
  4. Switch between all three themes and verify header appearance
  5. Test on mobile viewport (resize browser or use dev tools)

Notes

@devin-ai-integration @lukeepage2
Update header to white background with black text matching Figma design
15d6903 
- Changed header background to white (#ffffff) for all themes
- Updated header text and navigation colors from white to black
- Changed cog.svg icon from white to black fill for visibility
- Updated logo-inner backgrounds to subtle gray (#f5f5f5) for depth

Co-Authored-By: Luke Page <[email protected]>
@devin-ai-integration
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant