Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataFrame interactive widget, widget sub-module, resources, and demo notebook. #238

Merged
merged 61 commits into from
Aug 13, 2021

Conversation

PokkeFe
Copy link
Collaborator

@PokkeFe PokkeFe commented Aug 13, 2021

  • Added the DataFrame interactive widget under the text_extensions_for_pandas.jupyter.widget module header.
  • Added necessary resource files to the text_extensions_for_pandas.resources module.
  • Added a demo notebook to the notebooks/ path. Note this demo relies on ipywidgets, which does not have a static counterpart and is not completely viewable from a static notebook viewer like Github's.

PokkeFe and others added 30 commits July 20, 2021 13:14
Seed widget branch with initial structure
Added a directory (html_edit) for creating custom ipywidgets.
Added interactive columns based on column datatype
Added handling of categorical data to interactive widget table
Added span rendering, controls, and modular refresh
Added button that allows adding additional rows to displayed dataframe
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@PokkeFe PokkeFe marked this pull request as ready for review August 13, 2021 17:14
@frreiss
Copy link
Member

frreiss commented Aug 13, 2021

There are some issues with Python 3.6 and the structure of the import statements. Stack trace:

[...]
~/pd/tep-viz/text_extensions_for_pandas/jupyter/widget/widget.py in <module>
     25 import ipywidgets as ipw
     26 from IPython.display import display, clear_output, HTML
---> 27 import text_extensions_for_pandas.jupyter.widget.span as tep_span
     28 import text_extensions_for_pandas.jupyter.widget.table as tep_table
     29 

AttributeError: module 'text_extensions_for_pandas' has no attribute 'jupyter'

To replicate, use env.sh to create a conda environment with Python 3.6.

Copy link
Member

@frreiss frreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, some minor comments inline.

text_extensions_for_pandas/jupyter/widget/widget.py Outdated Show resolved Hide resolved
text_extensions_for_pandas/jupyter/widget/span.py Outdated Show resolved Hide resolved
text_extensions_for_pandas/jupyter/widget/span.py Outdated Show resolved Hide resolved
text_extensions_for_pandas/jupyter/widget/span.py Outdated Show resolved Hide resolved
text_extensions_for_pandas/jupyter/widget/table.py Outdated Show resolved Hide resolved
text_extensions_for_pandas/jupyter/widget/table.py Outdated Show resolved Hide resolved
text_extensions_for_pandas/jupyter/widget/widget.py Outdated Show resolved Hide resolved
text_extensions_for_pandas/jupyter/widget/widget.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants