Add missing err:out_of_range code-sections + intent fixes#1
Closed
gramss wants to merge 1 commit intoCMU-cabot:reload-treefrom
Closed
Add missing err:out_of_range code-sections + intent fixes#1gramss wants to merge 1 commit intoCMU-cabot:reload-treefrom
gramss wants to merge 1 commit intoCMU-cabot:reload-treefrom
Conversation
18 tasks
Author
|
As BehaviorTree#61 was merged, this is now tracked here: BehaviorTree#96 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I was able to test your PR against my PR of adding Groot Monitoring to Nav2: ros-navigation/navigation2#1958
Your PR helped dealing with everything related reloading the Tree on Groot side IF the (ZMQ) connection between Nav2/status publisher and Groot stays OPEN. (Great work, thanks!!)
But, when you disconnect Groot and build a new tree (nav2 = reset lifecycle node) so that the tree gets a new UID, then it still fails. So I "just" grabbed all the remaining code with references to the UID and placed it inside the Try/catch.
Worked like a charm. Also did some small intend fixed (tabs).
Please accept this PR in the pure hope that this will be added to your existing PR: BehaviorTree#61
Cheers from Germany 🍻