Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPC-4114: Fix Sync Organization #2192

Merged
merged 1 commit into from
Jun 12, 2024
Merged

DPC-4114: Fix Sync Organization #2192

merged 1 commit into from
Jun 12, 2024

Conversation

jdettmannnava
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/DPC-4114

🛠 Changes

DpcClient returns FHIR:Bundle from get_organization_by_npi

ℹ️ Context for reviewers

get_organization_by_npi was trying to unmarshall the wrong object

✅ Acceptance Validation

  • Updated tests
  • Ran SyncOrganizationJob in dpc-portal rails console, and it interacted with the backend appropritately

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

Copy link
Contributor

@ashley-weaver ashley-weaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@jdettmannnava jdettmannnava requested review from ashley-weaver and a team June 12, 2024 20:00
@jdettmannnava jdettmannnava merged commit 639d2d5 into main Jun 12, 2024
4 checks passed
@jdettmannnava jdettmannnava deleted the jd/dpc-4114-fix-sync branch June 12, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants