Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPC-3995 Block Access on Verification Failure #2180

Merged
merged 11 commits into from
Jun 4, 2024

Conversation

jdettmannnava
Copy link
Contributor

@jdettmannnava jdettmannnava commented May 28, 2024

🎫 Ticket

https://jira.cms.gov/browse/DPC-3995

🛠 Changes

  • Created IconComponent and AccessDeniedComponent
  • OrganizationCardComponent: shows status; uses link instead of organization
  • OrganizationListComponent: sends links to OrganizationCard; removed search; adds AO header
  • ApplicationController: shared before_hooks for access control
  • ClientTokenController, IpAddressController, PublicKeyController, OrganizationController: uses shared before_hooks for access control
  • User: returns links instead of organizations to support card component
  • CdOrgLink: added verification_status to quack like duck
  • AoLoadingComponent removed as no longer used

ℹ️ Context for reviewers

The weekly verification check may remove access to the portal for CDs and AOs due to various verification failures. The changes in the ticket block access under these conditions and explain why they are blocked. We do not have CD-specific messaging at this point.

✅ Acceptance Validation

Manual and automated testing:

AO

AO with med sanctions

AO med sanctions

Org has med sanctions

AO org med sanctions list
AO org med sanctions screen

Org does not have approval

AO no enrolllment list
AO no enrollment screen

User no longer AO

User not AO List
User not AO Screen

CD

All Good

Cd list

Org has med sanctions

CD org med sanctions list
CD org med sanctions screen

Org does not have approval

CD no enrollment list
CD no enrollment screen

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@jdettmannnava jdettmannnava changed the title Jd/dpc 3995 verification failure UI DPC-3995 Block Access on Verification Failure May 28, 2024
@jdettmannnava jdettmannnava requested a review from a team May 29, 2024 15:53
@jdettmannnava jdettmannnava marked this pull request as ready for review May 29, 2024 15:53
Copy link
Contributor

@MEspositoE14s MEspositoE14s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm far from a Rails expert, but from a 1,000ft level it seems good to me!

@jdettmannnava jdettmannnava merged commit 0452509 into main Jun 4, 2024
4 checks passed
@jdettmannnava jdettmannnava deleted the jd/dpc-3995-verification-failure-ui branch June 4, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants