Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec to cover sessions controller #2159

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

ashley-weaver
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/DPC-xxx

🛠 Changes

(What was added, updated, or removed in this PR.)

ℹ️ Context for reviewers

(Background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers.)

✅ Acceptance Validation

(How were the changes verified? Did you fully test the acceptance criteria in the ticket? Provide reproducible testing instructions and screenshots if applicable.)

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@ashley-weaver ashley-weaver requested a review from a team April 30, 2024 19:41
@ashley-weaver ashley-weaver marked this pull request as ready for review April 30, 2024 19:41
Copy link
Contributor

@jdettmannnava jdettmannnava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashley-weaver ashley-weaver merged commit 37df078 into master Apr 30, 2024
4 checks passed
@ashley-weaver ashley-weaver deleted the aweaver/add-test-coverage branch April 30, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants