Remove ruby patch level from rails app's base image #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashley-weaver
approved these changes
Apr 29, 2024
jdettmannnava
commented
May 7, 2024
| @@ -1,7 +1,7 @@ | |||
| source 'https://rubygems.org' | |||
| git_source(:github) { |repo| "https://github.com/#{repo}.git" } | |||
|
|
|||
| ruby '3.3.0' | |||
| ruby '~>3.3' | |||
There was a problem hiding this comment.
@CMSgov/dpc-dev : do you think we should have it like this, where it changes automatically, or should we pin it, so it will fail on patch upgrade and we can test that separately?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-4046
🛠 Changes
ruby:3.3.0-alpinetoruby:3.3-alpineFROM openjdkstanza from dpc-webℹ️ Context for reviewers
The new container policy recommends building from the minor version rather than patch to ensure security updates.
✅ Acceptance Validation
(How were the changes verified? Did you fully test the acceptance criteria in the ticket? Provide reproducible testing instructions and screenshots if applicable.)
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.