Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPC-4026] Setup activerecord-session_store gem #2151

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

MEspositoE14s
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/DPC-4026

🛠 Changes

Added and configured the activerecord-session_store gem so that sessions are stored in the DB.

ℹ️ Context for reviewers

This should allow us to securely store a users IdP auth token in their session.

✅ Acceptance Validation

Ran dpc-portal locally and verified that rows were created in the session table when I accessed the site.

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@MEspositoE14s MEspositoE14s requested a review from a team April 23, 2024 19:20
Copy link
Contributor

@jdettmannnava jdettmannnava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dpc-portal/config/initializers/session_store.rb Outdated Show resolved Hide resolved
dpc-portal/config/environments/production.rb Outdated Show resolved Hide resolved
@MEspositoE14s MEspositoE14s merged commit 4966807 into master Apr 26, 2024
4 checks passed
@MEspositoE14s MEspositoE14s deleted the me/dpc-4026-store-login-sessions-in-db branch April 26, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants