[WNMGDS-2669] Make token changes informed by Figma migration #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is the same value ultimately
pwolfert
added
Type: Breaking
zarahzachz
reviewed
Feb 12, 2024
There was a problem hiding this comment.
I ran yarn test:browser:all and got 1 failure
~[webkit] › stories.test.ts:72:13 › Components/Button/All Anchor Buttons › with core theme › matches snapshot ~
it doesn't make a whole lotta sense given you didn't change any button tokens though
scratch that - all tests pass a 2nd time through
| @@ -280,7 +280,6 @@ export const components: AnyTokenValues = { | |||
| '__background-color': t.color['white'], | |||
| '__padding': t.spacer['4'], | |||
| '-overlay__background-color': t.color['background-dialog-mask'], | |||
| '-icon__size': '0.8125rem', | |||
|
@zarahzachz, what was the visual error you got? What did it look like? I ran the full VRTs on my own computer and didn't get anything. |
zarahzachz
approved these changes
Feb 12, 2024
These didn't actually change content-wise, but storybook wants to render them slightly differently. I do believe the code this is based on is deterministic, but it's just not something we can practically determine on our own 😆
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renames
--table-striped__background-color--table__background-color--striped--table-striped-header__background-color--table-header__background-color--striped--form-hint__color--hint__color--form-hint__color--inverse--hint__color--inverse--form-error__color--inline-error__color--form-error__color--inverse--inline-error__color--inverseRemovals
--dialog-icon__size--icon__color--error--icon__color--inverse--icon__color--primary--icon__color--success--icon__color--warn--label__color--inverseChanged values
--alert__icon-sizenow usesremsinstead ofpxand accurately reflects the final size of those iconsHow to test
Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.