update cmake files for conda build #206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @beniz,
in order to make the code build on conda, we had to patch up the CMake configuration a bit.
Whether the python libraries have to be linked depends on the operating system:
-undefined dynamic_lookup
This PR takes care of this logic so that we don't need the
LINK_PYTHON
option any longer.Furthermore, the CMake build location for the library is
${PROJECT_BINARY_DIR}\\src
by default on Windows, which is added to the PATH for the C tests.Tagging @jschueller
Best,
Andreas