Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cmake files for conda build #206

Merged
merged 3 commits into from
May 27, 2020
Merged

update cmake files for conda build #206

merged 3 commits into from
May 27, 2020

Conversation

Olllom
Copy link
Contributor

@Olllom Olllom commented May 26, 2020

Hi @beniz,

in order to make the code build on conda, we had to patch up the CMake configuration a bit.

Whether the python libraries have to be linked depends on the operating system:

  • On Windows, they need to be linked
  • On MacOS, the Python module needs to be linked with -undefined dynamic_lookup
  • On Linux, they don't need to be linked

This PR takes care of this logic so that we don't need the LINK_PYTHON option any longer.

Furthermore, the CMake build location for the library is ${PROJECT_BINARY_DIR}\\src by default on Windows, which is added to the PATH for the C tests.

Tagging @jschueller

Best,
Andreas

@beniz
Copy link
Collaborator

beniz commented May 26, 2020

Hi, let me know when you need this merged, and if you need it despite the CI failure.

@jschueller
Copy link
Contributor

jschueller commented May 26, 2020

I guess there's still an issue with the dll path for tests, maybe retry without the path change ?

@Olllom
Copy link
Contributor Author

Olllom commented May 27, 2020

OK, ready to merge. Putting the more specific path first passed the CI.

@beniz beniz merged commit 4083409 into CMA-ES:master May 27, 2020
@beniz
Copy link
Collaborator

beniz commented May 27, 2020

Done. Do you need yet another release ?

@Olllom
Copy link
Contributor Author

Olllom commented May 27, 2020

Cool. Maybe not quite yet. Windows is somehow very picky about the order of the PATH directories. Therefore, we would still need a patch in the feedstock even with the current master. Let me try a little bit if I get a version to pass the tests on both your CI and the conda-forge CI. If this succeeds, I would be all for releasing a version that builds on conda-forge without patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants