isolate the definition of NOMINMAX #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly defined to not cause issue with other code that uses the definition.
Codecov ReportBase: 99.45% // Head: 99.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 18 18
Lines 4069 4071 +2
=======================================
+ Hits 4047 4049 +2
Misses 22 22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
henryiii
approved these changes
Feb 16, 2023
github-actions
bot
added
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isolate the definition of NOMINMAX further and skip undef if previously defined to not cause issue with other code that uses the definition.
This became an issue when using CLI11 in code that also included windows.h and made use of the NOMINMAX definition. There was a potential issue when CLI11 undefined it. This fix checks for the definition of NOMINMAX and leave it in place instead of undefining it.