Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set up coverage on GHA #747

Merged
merged 5 commits into from
Jun 27, 2022
Merged

ci: set up coverage on GHA #747

merged 5 commits into from
Jun 27, 2022

Conversation

henryiii
Copy link
Collaborator

This has been missing since we dropped Travis CI.

@henryiii henryiii force-pushed the henryiii/ci/coverage branch from 34f0e61 to 88cf3fa Compare June 27, 2022 15:14
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/ci/coverage branch from 88cf3fa to cca4090 Compare June 27, 2022 15:36
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@c781998). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #747   +/-   ##
=======================================
  Coverage        ?   99.46%           
=======================================
  Files           ?       12           
  Lines           ?     3958           
  Branches        ?        0           
=======================================
  Hits            ?     3937           
  Misses          ?       21           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c781998...5436750. Read the comment docs.

@henryiii henryiii force-pushed the henryiii/ci/coverage branch from 2b870c1 to 349b955 Compare June 27, 2022 16:09
@henryiii
Copy link
Collaborator Author

henryiii commented Jun 27, 2022

This is a little worrisome:

D:\a\1\s\tests\HelpersTest.cpp(1231,82): error C2668: 'CLI::detail::lexical_conversion': ambiguous call to overloaded function [D:\a\1\s\build\tests\HelpersTest.vcxproj]
D:\a\1\s\include\CLI\TypeTools.hpp(1438,6): message : could be 'bool CLI::detail::lexical_conversion<std::array<double,4>,std::array<double,4>,(CLI::detail::enabler)0>(const std::vector<std::string,std::allocator<std::string>> &,AssignTo &)' [D:\a\1\s\build\tests\HelpersTest.vcxproj]
          with
          [
              AssignTo=std::array<double,4>
          ]
D:\a\1\s\include\CLI\TypeTools.hpp(1200,6): message : or       'bool CLI::detail::lexical_conversion<std::array<double,4>,std::array<double,4>,(CLI::detail::enabler)0>(const std::vector<std::string,std::allocator<std::string>> &,AssignTo &)' [D:\a\1\s\build\tests\HelpersTest.vcxproj]
          with
          [
              AssignTo=std::array<double,4>
          ]
D:\a\1\s\tests\HelpersTest.cpp(1231,82): message : while trying to match the argument list '(CLI::results_t, std::array<double,4>)' [D:\a\1\s\build\tests\HelpersTest.vcxproj]
D:\a\1\s\tests\HelpersTest.cpp(1239,77): error C2668: 'CLI::detail::lexical_conversion': ambiguous call to overloaded function [D:\a\1\s\build\tests\HelpersTest.vcxproj]
D:\a\1\s\include\CLI\TypeTools.hpp(1438,6): message : could be 'bool CLI::detail::lexical_conversion<std::array<double,4>,std::array<double,4>,(CLI::detail::enabler)0>(const std::vector<std::string,std::allocator<std::string>> &,AssignTo &)' [D:\a\1\s\build\tests\HelpersTest.vcxproj]
          with
          [
              AssignTo=std::array<double,4>
          ]
D:\a\1\s\include\CLI\TypeTools.hpp(1200,6): message : or       'bool CLI::detail::lexical_conversion<std::array<double,4>,std::array<double,4>,(CLI::detail::enabler)0>(const std::vector<std::string,std::allocator<std::string>> &,AssignTo &)' [D:\a\1\s\build\tests\HelpersTest.vcxproj]
          with
          [
              AssignTo=std::array<double,4>
          ]
D:\a\1\s\tests\HelpersTest.cpp(1239,77): message : while trying to match the argument list '(CLI::results_t, std::array<double,4>)' [D:\a\1\s\build\tests\HelpersTest.vcxproj]

This is the single header file on the top, I think it's the same error. Happens on C++latest/C++20 + windows-2022. I'll work around it for this PR by going back to windows-2019, but needs to be looked at.

@henryiii henryiii force-pushed the henryiii/ci/coverage branch from 03cfe25 to 5436750 Compare June 27, 2022 19:15
@henryiii henryiii marked this pull request as ready for review June 27, 2022 19:41
@henryiii henryiii merged commit 6ae1e1e into main Jun 27, 2022
@henryiii henryiii deleted the henryiii/ci/coverage branch June 27, 2022 19:41
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Jun 27, 2022
@henryiii henryiii removed the needs README Needs to be mentioned in the README label Sep 14, 2022
@henryiii henryiii removed the needs changelog Hasn't been added to the changelog yet label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant