Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for cycling through git rebase commands #45

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

bo5o
Copy link
Contributor

@bo5o bo5o commented Jul 18, 2023

Inspired by switch.vim

@CKolkey
Copy link
Owner

CKolkey commented Jul 18, 2023

Super cool idea! Two notes:

  1. Add a spec.
  2. If the user is using the single letter version, I think it would be a good idea to keep it to a single letter.

@CKolkey
Copy link
Owner

CKolkey commented Jul 18, 2023

(Don't worry about the failing SQL test - it sometimes misbehaves)

@bo5o
Copy link
Contributor Author

bo5o commented Jul 19, 2023

Added the spec.

About expanding the single letter versions:

I did kind of like the behavior of switch.vim to expand the single letter variant of the command into the more legible longer version. I might remember 'p' being 'pick', but what was 'r' again, 'reword' or 'reset', if I then remember that 'r' is 'reword', but I want 'reset', what was that again, and so on, you know?
If you want I can change it though.

@CKolkey
Copy link
Owner

CKolkey commented Jul 19, 2023

Alright, thats compelling enough for me :)

@bo5o bo5o force-pushed the feat/git-rebase-commands branch from f403863 to e550b15 Compare July 19, 2023 16:43
@CKolkey CKolkey merged commit 0787230 into CKolkey:master Jul 22, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants