Skip to content

Add vicen, vsnon to activate zap_small_areas#536

Merged
apcraig merged 1 commit into
CICE-Consortium:mainfrom
NickSzapiro-NOAA:zap_vicen_vsnon
Aug 1, 2025
Merged

Add vicen, vsnon to activate zap_small_areas#536
apcraig merged 1 commit into
CICE-Consortium:mainfrom
NickSzapiro-NOAA:zap_vicen_vsnon

Conversation

@NickSzapiro-NOAA
Copy link
Copy Markdown
Contributor

@NickSzapiro-NOAA NickSzapiro-NOAA commented Jul 31, 2025

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Add vicen, vsnon to activate zap_small_areas
  • Developer(s):
    Elizabeth Hunke, Denise Worthen
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    ufs-weather-model test case reproducer for negative dvice abort
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial . While differences in values are less than puny, resolves model abort elsewhere originating from ice volume but no area
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

Floating point math (e.g., in ridge_shift) may lead to tiny vicen increments without area that are not currently zapped. This zaps them too (+ similar logic for tiny vsnon). Closes #535

@apcraig
Copy link
Copy Markdown
Contributor

apcraig commented Aug 1, 2025

I ran a full test suite on derecho with 4 compilers and everything was bit-for-bit. This suggests that fixing this error either has no impact on the results in our test suite or the error was not triggered for any gridcells in any tests. I think it's great to get this fixed, and it's good that it's unlikely to have an impact on the solutions in many cases.

https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#227862610a87c6595de7ed6ea7583be228ca320b

Copy link
Copy Markdown
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to get this fixed! Thank you.

@apcraig apcraig merged commit 6a5c51e into CICE-Consortium:main Aug 1, 2025
2 checks passed
@DeniseWorthen
Copy link
Copy Markdown

Great to get this fix in. Hopefully it will resolve most (maybe all?) of the negdvice failures we've been struggling with.

@NickSzapiro-NOAA
Copy link
Copy Markdown
Contributor Author

@apcraig May I ask if you'd like me to make a PR on CICE side to update Icepack hash?

@apcraig
Copy link
Copy Markdown
Contributor

apcraig commented Aug 4, 2025

Hi @NickSzapiro-NOAA. On my list, I'll try to take care of it today. Thanks for checking in and offering!

uturuncoglu pushed a commit to oceanmodeling/Icepack that referenced this pull request Apr 3, 2026
Floating point math (e.g., in ridge_shift) may lead to tiny vicen increments without area that are not currently zapped. This zaps them too (+ similar logic for tiny vsnon). Closes CICE-Consortium#535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can ridging make negative ice volume ?

4 participants