Add vicen, vsnon to activate zap_small_areas#536
Merged
Conversation
Contributor
|
I ran a full test suite on derecho with 4 compilers and everything was bit-for-bit. This suggests that fixing this error either has no impact on the results in our test suite or the error was not triggered for any gridcells in any tests. I think it's great to get this fixed, and it's good that it's unlikely to have an impact on the solutions in many cases. |
apcraig
approved these changes
Aug 1, 2025
eclare108213
approved these changes
Aug 1, 2025
Contributor
eclare108213
left a comment
There was a problem hiding this comment.
Glad to get this fixed! Thank you.
|
Great to get this fix in. Hopefully it will resolve most (maybe all?) of the negdvice failures we've been struggling with. |
Contributor
Author
|
@apcraig May I ask if you'd like me to make a PR on CICE side to update Icepack hash? |
Contributor
|
Hi @NickSzapiro-NOAA. On my list, I'll try to take care of it today. Thanks for checking in and offering! |
uturuncoglu
pushed a commit
to oceanmodeling/Icepack
that referenced
this pull request
Apr 3, 2026
Floating point math (e.g., in ridge_shift) may lead to tiny vicen increments without area that are not currently zapped. This zaps them too (+ similar logic for tiny vsnon). Closes CICE-Consortium#535
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Add vicen, vsnon to activate zap_small_areas
Elizabeth Hunke, Denise Worthen
ufs-weather-model test case reproducer for negative dvice abort
Floating point math (e.g., in ridge_shift) may lead to tiny vicen increments without area that are not currently zapped. This zaps them too (+ similar logic for tiny vsnon). Closes #535