Update conserv_check implementation#318
Merged
Merged
Conversation
…epack driver namelist and to alt03 test, add conserv_check to icepack_parameters
Contributor
Author
|
This should be ready to merge. Once merged, I will add this to CICE-Consortium/CICE#450 and update CICE to leverage the new conserv_check icepack parameter argument. |
Merged
16 tasks
3 tasks
lettie-roach
pushed a commit
to lettie-roach/Icepack
that referenced
this pull request
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Update conserv_check implementation
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
All tests pass bit-for-bit on cheyenne
https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#75185037cf80be127deb9a1c26797ab72591e1bb
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on CICE or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
Please provide any additional information or relevant details below:
Rename l_conservation_check to conserv_check
Add conserv_check to namelist in icepack driver
Add conserv_check argument to icepack_parameters so it can be set by a driver
Add conserv_check to alt03 test
Update column_conservation_check fieldid strings
Update documentation including run of icepack.setup --docintfc