Skip to content

No ncat,ntrcr in call icepack_aggregate in ice_prescribed_mod.F90#979

Closed
NickSzapiro-NOAA wants to merge 2 commits into
CICE-Consortium:mainfrom
NOAA-EMC:develop
Closed

No ncat,ntrcr in call icepack_aggregate in ice_prescribed_mod.F90#979
NickSzapiro-NOAA wants to merge 2 commits into
CICE-Consortium:mainfrom
NOAA-EMC:develop

Conversation

@NickSzapiro-NOAA
Copy link
Copy Markdown
Contributor

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Compile fix for icepack_aggregate call in ice_prescribed_mod (maybe missed during refactor)
  • Developer(s):
    Nicholas Szapiro
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    UFS regression testing in Support IntelLLVM compiler ufs-community/ufs-weather-model#2224
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

Copy link
Copy Markdown
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this error also exists in

cicecore/drivers/mct/cesm1/ice_prescribed_mod.F90

Would you might fixing it there as well, I know you can't test. Thanks!

@NickSzapiro-NOAA
Copy link
Copy Markdown
Contributor Author

Sure. Let me use a different branch for this PR then:
#980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants