Skip to content

A new driver/coupler for GEOS-ESM#959

Closed
zhaobin74 wants to merge 89 commits into
CICE-Consortium:mainfrom
GEOS-ESM:geos-ready-for-consortium
Closed

A new driver/coupler for GEOS-ESM#959
zhaobin74 wants to merge 89 commits into
CICE-Consortium:mainfrom
GEOS-ESM:geos-ready-for-consortium

Conversation

@zhaobin74

Copy link
Copy Markdown
Contributor

PR checklist

  • Short (1 sentence) summary of your PR:
    This PR provides a new driver/coupler to NASA GMAO's GEOS-ESM.
  • Developer(s):
    @zhaobin74
  • Suggest PR reviewers from list in the column to the right.
    @eclare108213, @apcraig, @dabail10
  • Please copy the PR test results link or provide a summary of testing completed below.
    Full base_suite with both base tag (main) and this PR and got bit-for-bit identical results
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.
    • Adds a new driver for GEOS-ESM under drivers/mapl/geos
    • Adds a separate land sea mask to run thermodynamics ONLY
    • When proper, use GEOSCOUPLED macro to isolate the relevant code specific to GEOS
    • Depends on Coupling support for GEOS-ESM Icepack#491

Hi Consortium, this PR is two years of efforts to bring in CICE6/Icepack to GEOS-ESM coupled model. We have been successfully using it in our coupled GEOS-MOM6-CICE6 experiments. I appreciate your review and feedbacks and am happy to improve it along the way. Thank you.

* first attempt at enabling c-evp

* corrected n/e mask; set u/vocn properly
* add passing optional time stamp to ice_checkpoint

* make ice_checkpoint accessible by the plug
…elimination

keep all-land blocks when coupling to GEOS-ESM
* move advance_calendar into ice_step such that only corrector step moves dates forward

* a module for recording and restoring thermo state added

* add protection for trcrn_save being not allocated

* need to save addtional states to restore later; turn on print out

* zero out many fluxes which could have accumulated during predictor step
@apcraig

apcraig commented Mar 16, 2025

Copy link
Copy Markdown
Contributor

This is superceded by #1012. Will close now, please move discussion there. This PR is still available for comparison with #1012 in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants