Fix Github Actions for macos system update#948
Merged
Conversation
eclare108213
approved these changes
May 1, 2024
Contributor
eclare108213
left a comment
There was a problem hiding this comment.
Really, it's a zero-character modification? Thanks for dealing with this (over and over).
Contributor
Author
|
It's not fixed yet, need to trigger github actions to debug. First mod was adding a trivial change to create the PR, still trying to figure out what's happening. Unfortunately, I need to debug in the PR. |
Contributor
|
I see. Would it not work to PR into another branch of your own? |
Contributor
Author
|
True, I could test it in my fork first. That would require I explicitly turn on the github actions on that branch in my fork. Sort of easier just to do it in regular PR as long as others don't mind too much :) |
Contributor
Author
|
This is ready for merge. |
anton-seaice
pushed a commit
to ACCESS-NRI/CICE
that referenced
this pull request
May 1, 2024
Github Actions broke again after default macos system update. Clang was not picking up the C system files. Had to change the implementation and add -isysroot to the CFLAGS option. At the same time, removed prior implementation where the system files were linked into /usr/local/include, this was no longer working.
NickSzapiro-NOAA
pushed a commit
to NickSzapiro-NOAA/CICE
that referenced
this pull request
May 2, 2024
Github Actions broke again after default macos system update. Clang was not picking up the C system files. Had to change the implementation and add -isysroot to the CFLAGS option. At the same time, removed prior implementation where the system files were linked into /usr/local/include, this was no longer working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Fix latest problem with Github Actions for macos system update
apcraig
TBD
Github Actions broke again after default macos system update.
Clang was not picking up the C system files. Had to change the implementation and add -isysroot to the CFLAGS option. At the same time, removed prior implementation where the system files were linked into /usr/local/include, this was no longer working.