Skip to content

Update Icepack to #5999551 including snowbrinebugs #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apcraig merged 2 commits into from
Dec 2, 2022
Merged

Update Icepack to #5999551 including snowbrinebugs #797

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a65c13
Update Icepack to #5999551
apcraig Nov 30, 2022
caaa22f
Update advection scheme descriptions
apcraig Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions cicecore/cicedyn/analysis/ice_history.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,10 +420,6 @@ subroutine init_hist (dt)
f_taubyE = f_tauby
endif

#ifndef ncdf
f_bounds = .false.
#endif

! write dimensions for 3D or 4D history variables
! note: list of variables checked here is incomplete
if (f_aicen(1:1) /= 'x' .or. f_vicen(1:1) /= 'x' .or. &
Expand Down
2 changes: 1 addition & 1 deletion doc/source/science_guide/sg_horiztrans.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ versions but have not yet been implemented.

Two transport schemes are available: upwind and the incremental
remapping scheme of :cite:`Dukowicz00` as modified for sea ice by
:cite:`Lipscomb04`. The upwind scheme is naturally suited for a C grid discretization. As such, the C grid velocity components (i.e. :math:`uvelE=u` at the E point and :math:`vvelN=v` at the N point) are directly passed to the upwind transport scheme. On the other hand, if the B grid is used, :math:`uvel` and :math:`vvel` (respectively :math:`u` and :math:`v` at the U point) are interpolated to the E and N points such that the upwind advection can be performed. Conversely, as the remapping scheme was originally developed for B grid applications, :math:`uvel` and :math:`vvel` are directly used for the advection. If the remapping scheme is used for the C grid, :math:`uvelE` and :math:`vvelN` are first interpolated to the U points before performing the advection.
:cite:`Lipscomb04`. The upwind scheme is naturally suited for a C grid discretization. As such, the C grid velocity components (i.e. :math:`uvelE=u` at the E point and :math:`vvelN=v` at the N point) are directly passed to the upwind transport scheme. On the other hand, if the B grid is used, :math:`uvelU` and :math:`vvelU` (respectively :math:`u` and :math:`v` at the U point) are interpolated to the E and N points such that the upwind advection can be performed. Conversely, as the remapping scheme was originally developed for B grid applications, :math:`uvelU` and :math:`vvelU` are directly used as departure points for the advection. If the remapping scheme is used for the C grid, :math:`uvelE` and :math:`vvelN` are first interpolated to the U points before performing the advection.

@eclare108213 eclare108213 Dec 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JFLemieux73 @TillRasmussen: do you agree with this statement?

:cite:Lipscomb04. The upwind scheme is naturally suited for a C grid discretization. As such, the C grid velocity components (i.e. :math:uvelE=u at the E point and :math:vvelN=v at the N point) are directly passed to the upwind transport scheme. (Note however that the upwind scheme does not transport all potentially available tracers.) On the other hand, if the B grid is used, :math:uvelU and :math:vvelU (respectively :math:u and :math:v at the U point) are interpolated to the E and N points such that the upwind advection can be performed. Because the remapping scheme was originally developed for B grid applications, uvelU and vvelU are are interpolated to the E and N points internally in the advection code, when running on B grids. If the remapping scheme is used for the C grid, :math:uvelE and :math:vvelN are first interpolated to the U points before performing the advection when l_fixed_area (described below) is false.

@TillRasmussen TillRasmussen Dec 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting from:
Because the remapping scheme was originally developed for B grid applications, uvelU and vvelU are are interpolated to the E and N points internally in the advection code, when running on B grids. If the remapping scheme is used for the C grid, :math:uvelE and :math:vvelN are first interpolated to the U points before performing the advection when l_fixed_area (described below) is false.

I would reformulate the above to
The remapping scheme was originally developed for B grid applications, which means that  :math:uvelU and :math:vvelU are needed. If l_fixed_area is true (by default hardcoded to false) then :math:uvelE and :math:vvelN are needed, which requires interpotation. If the remapping scheme is used for the C grid, :math:uvelE and :math:vvelN are first interpolated to the U points before performing the advection when l_fixed_area (described below) is false.

"Not to be included"
The interpolation on B grid from uvelU and vvelN are not needed in the current setting, however it is done anyway.



The remapping scheme has several desirable features:
Expand Down
2 changes: 1 addition & 1 deletion icepack
Open in desktop
Submodule icepack updated 4 files
+14 −0 .github/workflows/test-icepack.yml
+12 −8 columnphysics/icepack_snow.F90
+2 −2 columnphysics/icepack_therm_itd.F90
+1 −1 columnphysics/icepack_therm_vertical.F90