Update KE diagnostic#784
Merged
Merged
Conversation
- Average U and V fields to T grid for KE calculation for B, C, and CD grid, raw U and V were combined with T grid variables in prior implementation. Also - Update max speed calculation for C grid, calc speed at both E and N points - Refactor highfreq option u,v passed into icepack for windstress calculation - This is bit-for-bit - Create local variables uvelT_icep and vvelT_icep to store highfreq info - Compute [uvelT,vvelT]_icep at start of therm calc instead of end of dynamics calc - No longer need to recalc [uvelT,vvelT]_icep on restart - Update some indentation in ice_diagnostics.F90
eclare108213
approved these changes
Nov 4, 2022
Contributor
eclare108213
left a comment
There was a problem hiding this comment.
This might break restarts from previous-version restart files, but that will be fine going forward and otherwise it looks good. Thanks for cleaning this up.
Contributor
Author
|
This doesn't affect prior restarts. Nothing has changed on the restart file. With this update, we just compute two derived quantities in a different place, but it's still there. |
Contributor
Author
Contributor
|
Looks good. Please merge when you're ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Update KE diagnostic
apcraig
Full test suite passes, all results bit-for-bit except KE, rms ice speed, and max speed on C-grid in log files. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#db254c11ba0a96b10f875a2d2003ec6aa9298073
Update KE diagnostic
Also
Closes #734
See also #655