Add time-varying wave forcing, add warning for FSD without waves, make FSD tendencies per second#775
Merged
eclare108213 merged 4 commits intoNov 1, 2022
Conversation
Contributor
eclare108213
left a comment
There was a problem hiding this comment.
This looks good to me. There should already be tests using this configuration, which is generalizing an existing one, but the new file will need to be posted with the rest of the (Icepack) forcing files.
Contributor
|
This all looks fine to me, I may run a few tests separately. I don't see any new file needed. Where does the new file come in? |
apcraig
approved these changes
Oct 19, 2022
Contributor
apcraig
left a comment
There was a problem hiding this comment.
I ran a small suite of fsd tests and everything seems to pass and be bit-for-bit as currently implemented using the current test file.
PASS narwhal_gnu_smoke_gx3_4x2_debug_diag24_fsd1_run5day test
PASS narwhal_gnu_smoke_gx3_8x2_diag24_fsd12_run5day test
PASS narwhal_gnu_smoke_gx3_8x2_diag24_fsd12ww3_run1day test
PASS narwhal_gnu_smoke_gx3_14x2_fsd12_histall test
PASS narwhal_gnu_smoke_gx3_14x2_fsd12_reprosum_run10day test
PASS narwhal_gnu_smoke_gx3_8x1_cmplogrest_fsd12_reprosum_run10day_thread test
PASS narwhal_gnu_smoke_gx3_14x2_fsd12_gridc_reprosum_run10day test
PASS narwhal_gnu_smoke_gx3_8x1_cmplogrest_fsd12_gridc_reprosum_run10day_thread test
PASS narwhal_gnu_smoke_gx3_14x2_fsd12_gridcd_reprosum_run10day test
PASS narwhal_gnu_smoke_gx3_8x1_cmplogrest_fsd12_gridcd_reprosum_run10day_thread test
PASS narwhal_gnu_smoke_gx3_8x2_diag1_run5day test
PASS narwhal_gnu_smoke_gx3_1x1_diag1_run1day test
PASS narwhal_gnu_restart_gbox128_8x1_diag1 test
PASS narwhal_gnu_restart_gx3_4x2_debug_diag1 test
PASS narwhal_gnu_smoke_gx3_4x1_diag1_run5day_thread test
PASS narwhal_gnu_unittest_gx3_1x1_helloworld test
PASS narwhal_gnu_unittest_gx3_1x1_optargs test
PASS narwhal_gnu_unittest_gx3_4x1x25x29x4_sumchk test
PASS narwhal_gnu_unittest_gx3_1x1x25x29x16_sumchk test
PASS narwhal_gnu_unittest_tx1_8x1_sumchk test
PASS narwhal_gnu_unittest_gx3_4x1_bcstchk test
PASS narwhal_gnu_unittest_gx3_1x1_bcstchk test
PASS narwhal_gnu_unittest_gx3_8x2_dwblockall_gridavgchk test
PASS narwhal_gnu_unittest_gx3_12x1_gridavgchk test
PASS narwhal_gnu_unittest_gx1_28x1_dwblockall_gridavgchk test
PASS narwhal_gnu_unittest_gx1_16x2_gridavgchk test
PASS narwhal_gnu_unittest_gbox128_8x2_gridavgchk test
Contributor
|
I think this can be merged. We can create a new PR when we have a new fsd dataset. Anyone disagree? |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Add time-varying wave forcing, add warning for FSD without waves, make FSD tendencies per second
Lettie Roach
@eclare108213 @apcraig
No testing done
(@eclare108213 edited to remove spaces from the checkboxes)