Update box test options#772
Merged
Merged
Conversation
- refactor options boxsym and boxislands to boxopen, boxclosed, and boxforce - update box test names as needed - update calculation of test suite failures in cice.results.csh - add documentation to user guide for rectangular grids
Contributor
Author
Member
Thanks for addressing! |
eclare108213
approved these changes
Oct 14, 2022
Contributor
eclare108213
left a comment
eclare108213
left a comment
There was a problem hiding this comment.
Awesome, thank you.
Contributor
Author
|
Should have closed the issues, not sure why it didn't. Sometimes it works, sometimes not. I'll do it manually now. |
This was referenced Oct 14, 2022
Member
|
The "Closes" mentions have to be in the PR description itself (or in a commit message). It does not work in subsequent comments on the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Update box tests
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
Results are bit-for-bit on cheyenne with 3 compilers. Some test names changed, a random handful were compared to prior results manually and are also bit-for-bit. A few tests are new. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#0bd06542eb9de37bb37b9ddfcf2bd701e07fa941
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on Icepack or any other models?
Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
Please provide any additional information or relevant details below:
refactor options boxsym and boxislands to boxopen, boxclosed, and boxforce
update box test names as needed
update calculation of test suite failures in cice.results.csh
add documentation to user guide for rectangular grids