Skip to content

Correct units in FSD history output#769

Merged
eclare108213 merged 1 commit into
CICE-Consortium:mainfrom
lettie-roach:fsd_units_correction
Oct 11, 2022
Merged

Correct units in FSD history output#769
eclare108213 merged 1 commit into
CICE-Consortium:mainfrom
lettie-roach:fsd_units_correction

Conversation

@lettie-roach
Copy link
Copy Markdown
Contributor

@lettie-roach lettie-roach commented Oct 10, 2022

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Correcting units on history output for the FSD
  • Developer(s):
    Lettie Roach
  • Suggest PR reviewers from list in the column to the right.
    @eclare108213 @apcraig
  • Please copy the PR test results link or provide a summary of testing completed below.
    No testing
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

@phil-blain
Copy link
Copy Markdown
Member

One small nit, since the PR title becomes the commit title: maybe something more explicit, like

Correct units in FSD history output

?

@lettie-roach lettie-roach changed the title Correct units in history output Correct units in FSD history output Oct 11, 2022
@eclare108213
Copy link
Copy Markdown
Contributor

Thanks for updating the title, @lettie-roach.

@eclare108213 eclare108213 merged commit af8cc84 into CICE-Consortium:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants