Change visc_method default to avg_zeta#744
Merged
Merged
Conversation
dabail10
approved these changes
Aug 2, 2022
eclare108213
approved these changes
Aug 2, 2022
| echo "\$jobid \${ICE_TESTNAME} " >> ../suite.jobs | ||
| else if (\${dorun} == true) then | ||
| ./cice.test | ||
| if (\$bldstat == 0) then |
Contributor
There was a problem hiding this comment.
Thank you, I was wishing for this change last week!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Change visc_method default to avg_zeta, change alt07 to test avg_strength
apcraig
full test suite on cheyenne indicates several failures with visc_method=avg_zeta that didn't failed with avg_strength, only for gridCD, no problem with gridB or gridC. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#063a7f2151ec20571d641af0552f4ea182acb9b6
Also update the suite.submit to not submit jobs that don't build successfully.
Several gridCD test cases fail with avg_zeta, but passed with avg_strength. gridCD is not validated yet, so I will let these fail for now.
FAIL cheyenne_intel_smoke_gbox80_2x2_boxwallblock_gridcd run -1 -1 -1
FAIL cheyenne_intel_smoke_gbox80_4x1_boxsyme_gridcd_kmtislands_run1day run -1 -1 -1
FAIL cheyenne_intel_smoke_gbox80_4x2_boxislandse_gridcd_run1day run -1 -1 -1
FAIL cheyenne_intel_smoke_gbox128_8x2_gridcd_reprosum_run10day run -1 -1 -1
FAIL cheyenne_intel_smoke_gbox128_8x1_cmplogrest_gridcd_reprosum_run10day_thread run -1 -1 -1
FAIL cheyenne_pgi_smoke_gbox80_2x2_boxwallblock_gridcd run -1 -1 -1
FAIL cheyenne_pgi_smoke_gbox80_4x1_boxsyme_gridcd_kmtislands_run1day run -1 -1 -1
FAIL cheyenne_pgi_smoke_gbox80_4x2_boxislandse_gridcd_run1day run -1 -1 -1
FAIL cheyenne_pgi_smoke_gx1_15x2_gridcd_reprosum_run10day_seabedprob run -1 -1 -1
FAIL cheyenne_pgi_smoke_gbox128_8x2_gridcd_reprosum_run10day run -1 -1 -1
FAIL cheyenne_pgi_smoke_gx1_18x1_cmplogrest_gridcd_reprosum_run10day_seabedprob_thread run -1 -1 -1
FAIL cheyenne_pgi_smoke_gbox128_8x1_cmplogrest_gridcd_reprosum_run10day_thread run -1 -1 -1
FAIL cheyenne_pgi_smoke_gx1_144x2_gx1prod_long_run10year run -1 -1 -1
FAIL cheyenne_gnu_smoke_gbox80_2x2_boxwallblock_gridcd run -1 -1 -1
FAIL cheyenne_gnu_smoke_gbox80_4x1_boxsyme_gridcd_kmtislands_run1day run -1 -1 -1
FAIL cheyenne_gnu_smoke_gbox80_4x2_boxislandse_gridcd_run1day run -1 -1 -1
FAIL cheyenne_gnu_smoke_gbox128_8x2_gridcd_reprosum_run10day run -1 -1 -1
FAIL cheyenne_gnu_smoke_gbox128_8x1_cmplogrest_gridcd_reprosum_run10day_thread run -1 -1 -1