Add unit test for optional arguments, "optargs"#730
Merged
Conversation
to pass optional arguments down the calling tree robustly whether they are present or not.
eclare108213
approved these changes
Jul 13, 2022
Contributor
Author
|
Test results for unittest_suite on cheyenne are here, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#7d89041e5381de5239ac8ee9ab47465c1f810f1e. |
dabail10
pushed a commit
to ESCOMP/CICE
that referenced
this pull request
Oct 4, 2022
* Add optargs "optional arguments" unit test. This tests the ability to pass optional arguments down the calling tree robustly whether they are present or not. * Add test to count optional arguments at 2nd level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Add unit test, optargs, to test ability to pass optional arguments down calling tree.
apcraig
unittest_suite passes on Cheyenne with 3 compilers.
This is a standalone serial unit test. It does not need any Icepack or CICE code. It simply tests the ability pass optional arguments down a calling tree robustly. It does so with a set of simple serial tests.
unittest_suite passes on Cheyenne with 3 compilers. It will be interesting to see if this test passes on all machines and compilers as we move forward. Initial results suggests this can be used inside Icepack for optional arguments which should provide a method to support optional arguments more simply.