Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions cicecore/cicedynB/general/ice_init.F90
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ subroutine input_data
albsnowv = 0.98_dbl_kind ! cold snow albedo, visible
albsnowi = 0.70_dbl_kind ! cold snow albedo, near IR
ahmax = 0.3_dbl_kind ! thickness above which ice albedo is constant (m)
atmbndy = 'default' ! or 'constant'
atmbndy = 'similarity' ! Atm boundary layer: 'similarity', 'constant' or 'mixed'
default_season = 'winter' ! default forcing data, if data is not read in
fyear_init = 1900 ! first year of forcing cycle
ycycle = 1 ! number of years in forcing cycle
Expand Down Expand Up @@ -1214,6 +1214,14 @@ subroutine input_data
endif
endif

if (trim(atmbndy) == 'default') then
if (my_task == master_task) then
write(nu_diag,*) subname//' WARNING: atmbndy = default'
write(nu_diag,*) subname//' WARNING: For backward compability, set atmbndy = similarity'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small wording suggestion:

Suggested change
write(nu_diag,*) subname//' WARNING: atmbndy = default'
write(nu_diag,*) subname//' WARNING: For backward compability, set atmbndy = similarity'
write(nu_diag,*) subname//' WARNING: "atmbndy = default" is deprecated, use "atmbndy = similarity"'
write(nu_diag,*) subname//' WARNING: setting atmbndy = similarity'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewritten

endif
atmbndy = 'similarity'
endif

if (formdrag) then
if (trim(atmbndy) == 'constant') then
if (my_task == master_task) write(nu_diag,*) subname//' ERROR: formdrag=T and atmbndy=constant'
Expand Down Expand Up @@ -1641,13 +1649,18 @@ subroutine input_data
write(nu_diag,1010) ' rotate_wind = ', rotate_wind,' : rotate wind/stress to computational grid'
write(nu_diag,1010) ' formdrag = ', formdrag,' : use form drag parameterization'
write(nu_diag,1000) ' iceruf = ', iceruf, ' : ice surface roughness at atmosphere interface (m)'
if (trim(atmbndy) == 'default') then
tmpstr2 = ' : stability-based boundary layer'
if (trim(atmbndy) == 'constant') then
tmpstr2 = ' : boundary layer uses bulk transfer coefficients'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change 'bulk' to 'constant' in this line. If I remember correctly, the overall parameterization we use is considered a 'bulk' formulation, and we're just choosing whether the coefficients are constant or not. Anyone please correct me if that's wrong. (And yes I used 'bulk' in the original comment!)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed / rewritten

elseif (trim(atmbndy) == 'similarity' .or. &
trim(atmbndy) == 'mixed') then
write(nu_diag,1010) ' highfreq = ', highfreq,' : high-frequency atmospheric coupling'
write(nu_diag,1020) ' natmiter = ', natmiter,' : number of atmo boundary layer iterations'
write(nu_diag,1002) ' atmiter_conv = ', atmiter_conv,' : convergence criterion for ustar'
elseif (trim(atmbndy) == 'constant') then
tmpstr2 = ' : boundary layer uses bulk transfer coefficients'
if (trim(atmbndy) == 'similarity') then
tmpstr2 = ' : stability-based boundary layer'
else
tmpstr2 = ' : stability-based boundary layer, but constant for sensible+latent heatfluxes'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about
' : stability-based wind stress, constant-coefficient sensible+latent heat fluxes'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed / rewritten

endif
else
tmpstr2 = ' : unknown value'
endif
Expand Down
2 changes: 1 addition & 1 deletion configuration/scripts/ice_in
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@

&forcing_nml
formdrag = .false.
atmbndy = 'default'
atmbndy = 'similarity'
rotate_wind = .true.
calc_strair = .true.
calc_Tsfc = .true.
Expand Down
2 changes: 1 addition & 1 deletion doc/source/cice_index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ either Celsius or Kelvin units).
"atm_data_dir", "directory for atmospheric forcing data", ""
"atm_data_format", "format of atmospheric forcing files", ""
"atm_data_type", "type of atmospheric forcing", ""
"atmbndy", "atmo boundary layer parameterization (‘default’ or ‘constant’)", ""
"atmbndy", "atmo boundary layer parameterization ('similarity', ‘constant’, or 'mixed')", ""
"avail_hist_fields", "type for history field data", ""
"awtidf", "weighting factor for near-ir, diffuse albedo", "0.36218"
"awtidr", "weighting factor for near-ir, direct albedo", "0.00182"
Expand Down
6 changes: 4 additions & 2 deletions doc/source/user_guide/ug_case_settings.rst
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,10 @@ forcing_nml
:widths: 15, 15, 30, 15

"", "", "", ""
"``atmbndy``", "``constant``", "bulk transfer coefficients", "``default``"
"", "``default``", "stability-based boundary layer", ""
"``atmbndy``", "string", "bulk transfer coefficients", "``similarity``"
"", "``similarity``", "stability-based boundary layer", ""
"", "``constant``", "constant-based boundary layer", ""
"", "``mixed``", "stability-based, but constant for sensible+latent heatfluxes", ""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise,
'stability-based wind stress, constant-coefficient sensible+latent heat fluxes'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed / rewritten

"``atmiter_conv``", "real", "convergence criteria for ustar", "0.0"
"``atm_data_dir``", "string", "path to atmospheric forcing data directory", ""
"``atm_data_format``", "``bin``", "read direct access binary atmo forcing file format", "``bin``"
Expand Down