Add iceruf to namelist

[phil-blain]

PR checklist

• Short (1 sentence) summary of your PR:
  Allow setting the ice surface roughness at the atmosphere interface, iceruf, in the CICE namelist. This makes it easier to modify this value.

• Developer(s):
  Original-pach-by: probably F. Roy or F. Dupont, ECCC

• Suggest PR reviewers from list in the column to the right.

• Please copy the PR test results link or provide a summary of testing completed below.

184 measured results of 184 total results
184 of 184 tests PASSED
0 of 184 tests PENDING
0 of 184 tests MISSING data
0 of 184 tests FAILED

• How much do the PR code changes differ from the unmodified code?
  • bit for bit
  • different at roundoff level
  • more substantial
• Does this PR create or have dependencies on Icepack or any other models?
  • Yes
  • No
• Does this PR add any new test cases?
  • Yes
  • No
• Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
  • Yes
  • No, does the documentation need to be updated at a later time?
    • Yes
    • No
• Please provide any additional information or relevant details below:

This is a another small step in bringing our in-house modifications back to the Consortium. More to come in the coming weeks / months.

[eclare108213]

Since iceruf is an icepack parameter, it will need to be added to the interface routines (init, query, etc). I suspect that if you tried to change its value in this version, you'd still get BFB with the unmodified code!

[phil-blain]

In fact it is already present in the Icepack interface, so I just had to wire it up in CICE. I'm passing iceruf to icepack_init_parameters here (last line):

CICE/cicecore/cicedynB/general/ice_init.F90

Lines 1788 to 1805 in 5d71476

	call icepack_init_parameters(ustar_min_in=ustar_min, albicev_in=albicev, albicei_in=albicei, &
	albsnowv_in=albsnowv, albsnowi_in=albsnowi, natmiter_in=natmiter, atmiter_conv_in=atmiter_conv, &
	emissivity_in=emissivity, &
	ahmax_in=ahmax, shortwave_in=shortwave, albedo_type_in=albedo_type, R_ice_in=R_ice, R_pnd_in=R_pnd, &
	R_snw_in=R_snw, dT_mlt_in=dT_mlt, rsnw_mlt_in=rsnw_mlt, &
	kstrength_in=kstrength, krdg_partic_in=krdg_partic, krdg_redist_in=krdg_redist, mu_rdg_in=mu_rdg, &
	atmbndy_in=atmbndy, calc_strair_in=calc_strair, formdrag_in=formdrag, highfreq_in=highfreq, &
	kitd_in=kitd, kcatbound_in=kcatbound, hs0_in=hs0, dpscale_in=dpscale, frzpnd_in=frzpnd, &
	rfracmin_in=rfracmin, rfracmax_in=rfracmax, pndaspect_in=pndaspect, hs1_in=hs1, hp1_in=hp1, &
	ktherm_in=ktherm, calc_Tsfc_in=calc_Tsfc, conduct_in=conduct, &
	a_rapid_mode_in=a_rapid_mode, Rac_rapid_mode_in=Rac_rapid_mode, &
	floediam_in=floediam, hfrazilmin_in=hfrazilmin, &
	aspect_rapid_mode_in=aspect_rapid_mode, dSdt_slow_mode_in=dSdt_slow_mode, &
	phi_c_slow_mode_in=phi_c_slow_mode, phi_i_mushy_in=phi_i_mushy, conserv_check_in=conserv_check, &
	wave_spec_type_in = wave_spec_type, &
	wave_spec_in=wave_spec, nfreq_in=nfreq, &
	tfrz_option_in=tfrz_option, kalg_in=kalg, fbot_xfer_type_in=fbot_xfer_type, &
	Pstar_in=Pstar, Cstar_in=Cstar, iceruf_in=iceruf, &

(see the diff). I think that's all that's needed, I did do a manual test by changing the iceruf value in the namelist.

[eclare108213]

Ah yes, sorry for missing that. Looks good, thanks.