Update Icepack, minor fixes from prerelease testing#590
Merged
Conversation
Fix error in gx1coreii initial condition filename Update conda macos Macros Add documentation about updating the conda environment
eclare108213
approved these changes
Apr 7, 2021
phil-blain
approved these changes
Apr 7, 2021
| CFLAGS_HOST := | ||
| else | ||
| CFLAGS_HOST = -isysroot $(SDKPATH) | ||
| LD += -L$(SDKPATH)/usr/lib |
Member
There was a problem hiding this comment.
I'm a little curious about why this is suddenly needed, but I guess something changed in the conda-forge toolchain...
Contributor
Author
There was a problem hiding this comment.
I don't know. This is what I had to do on my new mac running 11.2.1. I hadn't been able to run the conda macos before on this machine (although I had quickly tried before). I also had to make sure I updated my conda environment because I had an older install that had the omp bug. The extra LD could be a bug in the underlying conda setup, but I personally don't really know enough to be sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Update Icepack
apcraig
Tested mostly on conda. Changes are highly limited. Will undergo release testing once merged.
Fix error in gx1coreii initial condition filename
Update conda macos Macros
Add documentation about updating the conda environment