Skip to content

Update calls to scale_fluxes in all drivers#515

Merged
apcraig merged 1 commit into
CICE-Consortium:masterfrom
apcraig:scale_fluxes
Sep 22, 2020
Merged

Update calls to scale_fluxes in all drivers#515
apcraig merged 1 commit into
CICE-Consortium:masterfrom
apcraig:scale_fluxes

Conversation

@apcraig
Copy link
Copy Markdown
Contributor

@apcraig apcraig commented Sep 22, 2020

PR checklist

  • Short (1 sentence) summary of your PR:
    update calls to scale_fluxes associated with 4 separate flux terms (CICE addition of fswthru by components. #479) in all drivers
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    ran quick suite on cheyenne. changes cannot be tested in standalone mode as these are driver changes for coupled models. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#93b71ebb888c118ba9efd9ca163f78f5e35ce941
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

In #479, the interface to scale_fluxes was changed and updated in the standalone (and eventually nuopc/cmeps) driver code. But it was never updated in other drivers. This PR fixes that. The other drivers cannot be tested in standalone mode, so there still might be issues in further testing outside the Consortium, but this was a relatively straight-forward fix.

@apcraig apcraig merged commit b0a7ee6 into CICE-Consortium:master Sep 22, 2020
@apcraig apcraig deleted the scale_fluxes branch August 17, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants