update io_pio and io_pio2 for fsd input and output fields#444
Merged
Conversation
Contributor
|
I was about to email you with this. There are a couple issues. The interfaces for io_pio and io_pio2 are different for standalone and coupled. So, do we ifdef what we need here? Also, I can't figure out why it is not finding the subroutine pio_init. I'll email offline. |
dabail10
approved these changes
May 14, 2020
Contributor
Author
|
I'm going to merge this at this only affects pio code. We need this code to address some failures in #246. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Update io_pio and io_pio2 to handle fsd fields
apcraig
This was tested in RASM with io_pio. io_pio2 was copied from io_pio and then the pio_setframe call was updated. io_pio2 has not been tested. Standalone CICE testing does not test this code at the present time. Testing of the io_pio and io_pio2 code is inadequate. See further comments below.
Addresses #443.
Also related to #246.
This could be merged now, but depending on status of #246, we may want to do #246 first, with, or after this PR.