update cheyenne modules

[apcraig]

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

• Short (1 sentence) summary of your PR:
  Update cheyenne modules/compiler
• Developer(s):
  apcraig
• Suggest PR reviewers from list in the column to the right.
• Please copy the PR test results link or provide a summary of testing completed below.
  Test Results
• How much do the PR code changes differ from the unmodified code?
  • bit for bit except on cheyenne for some cases
  • different at roundoff level
  • more substantial
• Does this PR create or have dependencies on Icepack or any other models?
  • Yes
  • No
• Does this PR add any new test cases?
  • Yes
  • No
• Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
  • Yes
  • No, does the documentation need to be updated at a later time?
    • Yes
    • No
• Please provide any additional information or relevant details below:

Generally the debug and gbox cases are bit-for-bit with this upgrade, many other cases are not.

For the record, I tested intel/17.0.1, intel/18.0.5, and intel/19.0.2. We were using the intel/17 version before. This updates to the intel/19 version. The intel/18 version produced several test failures on exact restart. At this point, I think we can assume that's a compiler bug and given intel/19 is available, we can probably ignore it. The problem comes in when someone only has intel/18 and it might produce problems for them. Should we be debugging and working around compiler problems?

[apcraig]

Addresses #329 with Icepack PR268

[dabail10]

Looks fine.

[eclare108213]

I see no need to debug compilers as long as there is a work-around. If there is an obvious placce to put it (like "known issues" or the FAQ), maybe include a note that that particular compiler won't work with this version of the code.