update icepack, copyright, version number#326
Merged
Conversation
duvivier
approved these changes
Jun 21, 2019
Contributor
duvivier
left a comment
There was a problem hiding this comment.
Why are there so many more places in CICE that we have to change the date compared to Icepack? In any case there are no issues here from my end.
Contributor
Author
|
I realized after the fact that I missed one Copyright date in Icepack. I don't plan to fix it in the Icepack tag, but will after. I agree that we might want to consider if there are ways to consolidate the Copyright text somehow so we can share a single "file" that is used both in the documents and in the source code. I will create an issue to look into that. |
eclare108213
approved these changes
Jun 24, 2019
Contributor
eclare108213
left a comment
There was a problem hiding this comment.
I hope you found all of these! I agree it would be good to somehow automate these by connecting them to a single source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Update Icepack, copyright date, and version number is prep for 6.0.1 release
apcraig
#efdb29b4e2362f97d, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks
but only that it updates Icepack, there are no dependencies
Updated icepack to #efdb29b4e2362f97d == Icepack1.1.1
Changed Copyright date to 2019
Change CICE internal version number to 6.0.1