Update hycom forcing check and gbox128 tests batch time limit#315
Merged
Conversation
eclare108213
approved these changes
May 24, 2019
Contributor
eclare108213
left a comment
There was a problem hiding this comment.
This looks fine to me. It would be good if @mhrib can take a look also and test the ice_forcing change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update hycom forcing check, #273
Update some gbox128 tests to add short to add some extra batch queue time. Some of these tests were intermittently timing out on conrad due to time limits.
Developer(s): mhrib, tcraig
Are the code changes bit for bit, different at roundoff level, or more substantial? bit-for-bit
Does this PR create or have dependencies on Icepack or any other models? N
Is the documentation being updated with this PR? (Y/N) N
If not, does the documentation need to be updated separately at a later time? (Y/N) N
Other Relevant Details:
Tested with 4 compilers on conrad, all tests passed. #37b799c3e2, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks
Retested the failed test with updated short settings and all those tests passed (not shown).