Motification of doc for C-grid remapping#1034
Conversation
apcraig
left a comment
There was a problem hiding this comment.
It looks like the code uses l_EFA while the documentation suggests the variable name is l_EFA_area. Should these be consistent?
Thanks @apcraig. I just modified the doc. |
eclare108213
left a comment
There was a problem hiding this comment.
I'm not crazy about l_EFA, would prefer l_edge_flux_adj to be more immediately recognizable. But okay. Thanks for clarifying this parameter for users!
|
It is true that it is more easily recognizable. I will change it. No problem. |
|
I just changed the name of the variable. I redid the gbox80 tests and it is BFB for both B and C-grid (with ktransport=kridge=1). Thanks for your help! |
|
Thank you for fixing that! |
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Minor modifications to the documentation for C-grid remapping and edge flux adjustment method (EFA).
@JFLemieux73
BFB for B and C-grid gbox80 tests (with ktranposrt=kridge=1)
People from SI3 are interested in our C-grid remapping and edge flux adjustment method (EFA). They had a look at the code and the documentation. It was not clear in the code (and the doc) that the EFA method is used when setting l_fixed_area=.true. I have changed the name l_fixed_area to l_EFA, modified the doc and added the reference for the C-grid paper.