Skip to content

updates to LANL/Triad copyright and license#1030

Merged
apcraig merged 1 commit into
CICE-Consortium:mainfrom
eclare108213:copyright_license
May 22, 2025
Merged

updates to LANL/Triad copyright and license#1030
apcraig merged 1 commit into
CICE-Consortium:mainfrom
eclare108213:copyright_license

Conversation

@eclare108213
Copy link
Copy Markdown
Contributor

  • Short (1 sentence) summary of your PR:
    Updates LANL/Triad copyright and license per discussions with attorneys
  • Developer(s):
    @eclare108213
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Not tested pending further discussion regarding the drivers.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

LANL attorneys requested revisions to our copyright and license, following discussions with NOAA. This change separates the previous copyright/license notice into separate files, changes the Triad copyright date to "1998, 2017", and states that the license is standard BSD-3.

Similar changes will need to be made for Icepack.
Closes CICE-Consortium/About-Us#10
Closes CICE-Consortium/About-Us#21

@eclare108213
Copy link
Copy Markdown
Contributor Author

I went ahead and changed the copyright notices at the tops of all the drivers. That might be appropriate if they are not significantly different from the standalone (and mct/cesm1) drivers, but since LANL/Triad has never used most of the others and they were developed elsewhere for other codes, perhaps those should be copyrighted differently? Your thoughts, please. I'm willing to leave things as they are and make adjustments moving forward, but I'm also happy to discuss and fix anything you think is amiss.

Copy link
Copy Markdown
Contributor

@proteanplanet proteanplanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first look it seemed odd for Triad copyright to be marking drivers that are part of different groups' code, but upon examining the limited CICE code in which it appears, it makes sense, and it's just replacing the existing equivalent text. Thanks for fixing this to the satisfaction of various groups' legal departments.

@apcraig
Copy link
Copy Markdown
Contributor

apcraig commented May 20, 2025

There is one other file with the copyright in it,

cicecore/drivers/unittest/opticep/CICE.F90

That file is a copy of the file in the standalone/cice directory, you should be able to copy it directly.

@apcraig apcraig marked this pull request as ready for review May 22, 2025 00:10
@apcraig apcraig merged commit 45a7eae into CICE-Consortium:main May 22, 2025
2 checks passed
@eclare108213 eclare108213 deleted the copyright_license branch December 4, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updates to software copyright/license per LANL/Triad Consortium Documentation Organization

4 participants