Skip to content

Consistent character(char_len) :: stdname in cmeps cap#1029

Merged
apcraig merged 1 commit into
CICE-Consortium:mainfrom
NickSzapiro-NOAA:stdname_char_len
May 19, 2025
Merged

Consistent character(char_len) :: stdname in cmeps cap#1029
apcraig merged 1 commit into
CICE-Consortium:mainfrom
NickSzapiro-NOAA:stdname_char_len

Conversation

@NickSzapiro-NOAA
Copy link
Copy Markdown
Contributor

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Clean up -Wcharacter-truncation compiler warning via consistent character(char_len) :: stdname in cmeps cap
  • Developer(s):
    Nick Szapiro
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    bit-for-bit in UFS regression tests
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

For operational implementation, clean up compiler Warning: CHARACTER expression will be truncated in assignment (80/128) at (1) [-Wcharacter-truncation]. NUOPC standard names here are all shorter than 80 characters. Part of ufs-community/ufs-weather-model#2703

@apcraig apcraig merged commit e567bc0 into CICE-Consortium:main May 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants