Update job completion checking associated with testing#1025
Merged
Conversation
reporting. Latest version of slurm does not return the same error codes, so now we're switching to checking whether the job is in the queue explicitly.
Contributor
Author
|
Would like to get this merged before the weekend. |
dabail10
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Update job completion checking associated with testing
apcraig
This was tested on derecho (pbs) and blueback (slurm) with success. This only affects testing with automated reporting (--report) turned on.
Update job completion checking associated with testing and automated reporting. Latest version of slurm does not return the same error codes, so now we're switching to checking whether the job is in the queue explicitly. This only impacts automated test reporting (--report).