Skip to content

Update job completion checking associated with testing#1025

Merged
apcraig merged 1 commit into
CICE-Consortium:mainfrom
apcraig:jobchk
May 9, 2025
Merged

Update job completion checking associated with testing#1025
apcraig merged 1 commit into
CICE-Consortium:mainfrom
apcraig:jobchk

Conversation

@apcraig
Copy link
Copy Markdown
Contributor

@apcraig apcraig commented May 8, 2025

PR checklist

  • Short (1 sentence) summary of your PR:
    Update job completion checking associated with testing
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    This was tested on derecho (pbs) and blueback (slurm) with success. This only affects testing with automated reporting (--report) turned on.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

Update job completion checking associated with testing and automated reporting. Latest version of slurm does not return the same error codes, so now we're switching to checking whether the job is in the queue explicitly. This only impacts automated test reporting (--report).

reporting.  Latest version of slurm does not return the same error
codes, so now we're switching to checking whether the job is in the
queue explicitly.
@apcraig
Copy link
Copy Markdown
Contributor Author

apcraig commented May 8, 2025

Would like to get this merged before the weekend.

@apcraig apcraig merged commit 95e581e into CICE-Consortium:main May 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants