A bug fix mainly for the nvhpc compiler from the EarthWorks model

[dabail10]

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

• Short (1 sentence) summary of your PR:
  This is a bug fix only to ice_boundary.F90 to fix an issue with the nvhpc compiler and MPI calls. Found in the EarthWorks model.
• Developer(s):
  dabail10 (D. Bailey)
• Suggest PR reviewers from list in the column to the right.
• Please copy the PR test results link or provide a summary of testing completed below.
  https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#ce8cc304c78ef07265ef8e4f7739229eaee65573
• How much do the PR code changes differ from the unmodified code?
  • bit for bit
  • different at roundoff level
  • more substantial
• Does this PR create or have dependencies on Icepack or any other models?
  • Yes
  • No
• Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
  • Yes
  • No
• Does this PR add any new test cases?
  • Yes
  • No
• Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
  • Yes
  • No, does the documentation need to be updated at a later time?
    • Yes
    • No
• Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.
  This simply removes the 1:len in MPI calls.

[dabail10]

Sadly, gh-actions is failing. I don't know why.

[apcraig]

Sadly, gh-actions is failing. I don't know why.

Failure with github, have restarted it.

[apcraig]

I ran the quick suite on derecho for intel, cray, gnu, nvhpc, intelclassic, inteloneapi and tests passed as expected. nvhpc isn't bit-for-bit when we change decompositions, but that has always been the case. I chalk it up to a shortcoming in that compiler or maybe we need to further explore compiler options.