Update rectangular (box) configurations#1006
Merged
Merged
Conversation
- Fix bug where left hand side of rectangular grids had incorrect longitudes and latitudes computed. This changes answers in some box configurations. - Update the box resolutions. dxrect and dyrect were hardwired to 30km for all box resolutions. Now adjust dxrect and dyrect depending on the number of gridcells so it always covers an area of about 3 degrees by 3 degrees. This means gbox12 is 30km resolution, gbox80 is 5km, gbox128 is 3 km, and gbox180 is 2 km. Reduce the gbox180 timestep to 1800s for stability. This changes answers for some box configurations. - Remove u masking from box2001 ocean forcing, bit-for-bit. - Remove 50W check associated with box2001 initial conditions, bit-for-bit. - Add rectangular grid diagnostics - Minor update to the box2001 documentation Explicitly set npt_unit in all set_nml files that have npt set. Improves robustness where one option sets npt and another sets npt_unit.
dabail10
approved these changes
Feb 5, 2025
Contributor
dabail10
left a comment
There was a problem hiding this comment.
This looks good. Thanks for chasing this down.
eclare108213
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Update rectangular (box) configurations
apcraig
Several box tests change answers, as expected. This fixes a few bugs in the box setup. Non-box configurations pass and are bit-for-bit as expected. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#c3429c9a8f34869800e2ef8d06a2096be89d1d0e
Update the rectangular (box) grid configurations.
Explicitly set npt_unit in all set_nml files that have npt set. Improves robustness where one option sets npt and another sets npt_unit.
These changes do not fundamentally change how the model behaves with simple box test configurations. This just fixes a few inconsistencies in how the box grids are setup.
Closes #1004