Apply #18456 Fix controlled TextInput for Chinese (and other languages) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
yuya-fujimoto
approved these changes
Mar 23, 2018
|
Will this get pulled in to softcream-client automatically or we need this first merged to facebook/react-native and then it will get pulled in? |
|
Currently, we're using this forked repository, so this change will be automatically pulled in softcream-client. We might need to update |
|
Cool. I think we will need to create a new release though, so that the new version can be pulled in, otherwise I'm not sure if the client code will know about this change. "react-native": "~0.54.0" |
|
I sent a PR facebook#1310 to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply #18456 to fix TextInput bugs.
This PR is for
0.54-stable-flow-0.66branchRelated Issues at react-native: