Zero-weight 2D weighted straight skeletons #8796
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of this is not actually called, only compiled
sloriot
reviewed
Mar 31, 2025
| @@ -1606,13 +1609,18 @@ void Straight_skeleton_builder_2<Gt,Ss,V>::Propagate() | |||
| } | |||
|
|
|||
| ++ mStepID ; | |||
|
|
|||
| CGAL::draw(*mSSkel); | |||
There was a problem hiding this comment.
should be protected with the draw macro
There was a problem hiding this comment.
I was wondering why draw() not just is a no-op if the macro is not defined. Or just a std::cout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
TODO:
Release Management
Straight_skeleton_2,Straight_skeleton_extrusion_2All of this is not actually called, only compiled