Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMDS: Allow whitespace in the line #8793

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

afabri
Copy link
Member

@afabri afabri commented Mar 20, 2025

Summary of Changes

Make the function read_MEDIT() more tolerant.

Release Management

  • Affected package(s): SMDS_3
  • License and copyright ownership: unchanged

@afabri afabri changed the base branch from master to 6.0.x-branch March 20, 2025 15:54
@afabri afabri requested a review from sloriot March 20, 2025 15:55
@afabri afabri added this to the 6.0.2 milestone Mar 20, 2025
@afabri afabri self-assigned this Mar 20, 2025
@afabri
Copy link
Member Author

afabri commented Mar 21, 2025

We have another issue to fix. When I uncomment the calls to writing the mesh in the example mesh_polyhedral_complex_sm.cpp, and feed out.mesh into the example c3t3_example.cpp, and then load after_remeshing.mesh into CGALlab.exe many border facets are missing:

image

@afabri
Copy link
Member Author

afabri commented Mar 21, 2025

Note that when loading elephant.mesh which is the default everything is fine, so it must have to do with dealing with domains.

@MaelRL MaelRL added the TODO label Mar 21, 2025
@sloriot
Copy link
Member

sloriot commented Mar 24, 2025

Successfully tested in CGAL-6.1-Ic-114

@sloriot sloriot mentioned this pull request Mar 24, 2025
@sloriot sloriot merged commit 6a2c275 into CGAL:6.0.x-branch Mar 24, 2025
8 checks passed
@sloriot sloriot deleted the SMDS-read_MEDIT-GF branch March 24, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants