Tetrahedral_remeshing - fix edges accidentally removed from complex #8785
+111
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise it may happen that `e` is removed from complex, then Vertex_handle() is returned to cancel split, and `e` is not re-added to the complex
janetournois
force-pushed
the
Tetrahedral_remeshing-fix_split_constraints-jtournois
branch
2 times, most recently
from
5ef4f09 to
edbdfb2
Compare
…point can invert orientation this commit introduces a heuristic to try other split points, close to midpoint, and hope to find one that do not invert any incident tetrahedron to the edge to be split
janetournois
force-pushed
the
Tetrahedral_remeshing-fix_split_constraints-jtournois
branch
from
edbdfb2 to
1e553a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes for split step in tetrahedral remeshing :
Release Management