Mesh_3: Specific domain for Poisson reconstruction #8771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some documentation fixes
afabri
reviewed
Mar 5, 2025
afabri
reviewed
Mar 5, 2025
afabri
reviewed
Mar 5, 2025
afabri
reviewed
Mar 5, 2025
MaelRL
added
Not yet approved
There was a problem hiding this comment.
Remarks due to warnings in overnight documentation build https://cgal.geometryfactory.com/CGAL/Manual_doxygen_test/CGAL-6.1-Ic-108/logs_master/Poisson_surface_reconstruction_3.log
/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-108/include/CGAL/Poisson_mesh_domain_3.h:51: warning: Found non-existing group 'PkgMesh3Domains' for the command '@ingroup', ignoring command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-108/include/CGAL/Poisson_mesh_domain_3.h:46: warning: unexpected end of comment while inside <ul> block
/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-108/include/CGAL/Poisson_mesh_domain_3.h:120: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-108/include/CGAL/Poisson_mesh_domain_3.h:126: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-108/include/CGAL/Poisson_mesh_domain_3.h:183: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/cgal-testsuite/cgal_doc_build/CGAL-6.1-Ic-108/include/CGAL/Poisson_mesh_domain_3.h:189: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
Poisson_surface_reconstruction_3/include/CGAL/Poisson_mesh_domain_3.h
Outdated
Show resolved
Hide resolved
Poisson_surface_reconstruction_3/include/CGAL/Poisson_mesh_domain_3.h
Outdated
Show resolved
Hide resolved
Poisson_surface_reconstruction_3/include/CGAL/Poisson_mesh_domain_3.h
Outdated
Show resolved
Hide resolved
soesau
added
the
depends on another PR
|
depends on #8781 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/build:v0 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8771/v0/Manual/index.html |
MaelRL
removed
the
depends on another PR
|
/force-build:v0 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8771/v0/Manual/index.html |
MaelRL
reviewed
Mar 31, 2025
...e_reconstruction_3/doc/Poisson_surface_reconstruction_3/Poisson_surface_reconstruction_3.txt
Outdated
Show resolved
Hide resolved
...e_reconstruction_3/doc/Poisson_surface_reconstruction_3/Poisson_surface_reconstruction_3.txt
Outdated
Show resolved
Hide resolved
...e_reconstruction_3/doc/Poisson_surface_reconstruction_3/Poisson_surface_reconstruction_3.txt
Outdated
Show resolved
Hide resolved
Poisson_surface_reconstruction_3/include/CGAL/Poisson_mesh_domain_3.h
Outdated
Show resolved
Hide resolved
| * Indeed, the returned point is the first intersection of `[a,b]` | ||
| * with a subdomain surface. | ||
| */ | ||
| Intersection operator()(const Point_3& a, const Point_3& b) const |
There was a problem hiding this comment.
I'd leave a comment (undocumented) to explain somewhere why we use this class.
Also, couldn't we factorize the implementation with the Labeled mesh domain's (something akin to having an internal function that takes 2 points and a function and does the bisection)? We could probably just have this Construct_intersection inherits the base's too and only redefine the operator() (which would call the factorized internal function) and ..._object()
...e_reconstruction_3/doc/Poisson_surface_reconstruction_3/Poisson_surface_reconstruction_3.txt
Outdated
Show resolved
Hide resolved
...e_reconstruction_3/doc/Poisson_surface_reconstruction_3/Poisson_surface_reconstruction_3.txt
Show resolved
Hide resolved
Poisson_surface_reconstruction_3/include/CGAL/Poisson_mesh_domain_3.h
Outdated
Show resolved
Hide resolved
afabri
reviewed
Apr 1, 2025
...e_reconstruction_3/doc/Poisson_surface_reconstruction_3/Poisson_surface_reconstruction_3.txt
Outdated
Show resolved
Hide resolved
afabri
reviewed
Apr 1, 2025
...e_reconstruction_3/doc/Poisson_surface_reconstruction_3/Poisson_surface_reconstruction_3.txt
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8771/v1/Manual/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Creating Poisson_mesh_domain including optimizations for Poisson from Surface_mesher
Release Management
Poisson_implicit_surface_3for Mesh_3 (for CGAL-6.1) #8266