Add cut_with_plane and new fast clip method #8721
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaelRL
added
Not yet approved
sloriot
commented
Feb 7, 2025
| } | ||
| }; | ||
|
|
||
| // TODO here we should integrate the epsilon to reuse existing points (moving them on the grid as an option?) |
There was a problem hiding this comment.
actually we might want to move input points in the plane and update the oriented side.
afabri
reviewed
Mar 20, 2025
| * \cgalParamNBegin{geom_traits} | ||
| * \cgalParamDescription{an instance of a geometric traits class} | ||
| * \cgalParamType{a class model of `Kernel`} | ||
| * \cgalParamDefault{a \cgal Kernel deduced from the point type, using `CGAL::Kernel_traits`} |
There was a problem hiding this comment.
Suggested change
| * \cgalParamDefault{a \cgal Kernel deduced from the point type, using `CGAL::Kernel_traits`} | |
| * \cgalParamDefault{a \cgal kernel deduced from the point type, using `CGAL::Kernel_traits`} |
afabri
reviewed
Mar 20, 2025
| * If `tm` is closed, the clipped part can be closed too if the named parameter `clip_volume` is set to `true`. | ||
| * See Subsection \ref coref_clip for more details. | ||
| * | ||
| * \note `Plane_3` must be from the same %Kernel as the point of the internal vertex point map of `PolygonMesh`. |
There was a problem hiding this comment.
Here as well I would suggest to lowercase the word "kernel" as it is just a normal noun.
afabri
reviewed
Mar 20, 2025
| * @tparam NamedParameters a sequence of \ref bgl_namedparameters "Named Parameters" | ||
| * | ||
| * @param tm input triangulated surface mesh | ||
| * @param plane plane whose negative side defines the half-space to intersect `tm` with. |
There was a problem hiding this comment.
Suggested change
| * @param plane plane whose negative side defines the half-space to intersect `tm` with. | |
| * @param plane plane whose negative side defines the halfspace to intersect `tm` with. |
afabri
reviewed
Mar 20, 2025
| * \cgalParamType{Boolean} | ||
| * \cgalParamDefault{`false`} | ||
| * \cgalParamExtra{If this option is set to `true`, `tm` is no longer required to be without self-intersection. | ||
| * Setting this option to `true` will automatically set `throw_on_self_intersection` to `false` |
There was a problem hiding this comment.
Will it override in case I use the wrong value for throw_on_self_intersection ?
There was a problem hiding this comment.
that's what the last part of the sentence is saying. set -> reset would be better?
There was a problem hiding this comment.
Something like "overwrites" or "has precedence over a contradicting named parameter"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #6588
TODO
new_clip()toclip()(new_)split()PMP::kernel()based onclip()