Skip to content

Replace NULL and Nullptr_t with nullptr and nullptr_t#3979

Merged
lrineau merged 12 commits intoCGAL:masterfrom
afabri:CGAL-null_ptr-GF
Jun 17, 2019
Merged

Replace NULL and Nullptr_t with nullptr and nullptr_t#3979
lrineau merged 12 commits intoCGAL:masterfrom
afabri:CGAL-null_ptr-GF

Conversation

@afabri
Copy link
Member

@afabri afabri commented Jun 4, 2019

Summary of Changes

Replace NULL and Nullptr_t with nullptr and nullptr_t

Release Management

  • Affected package(s): all
  • Issue(s) solved (if any): fix #0000

@lrineau
Copy link
Member

lrineau commented Jun 6, 2019

Please try to compile the packages you modify, before pushing.

@afabri
Copy link
Member Author

afabri commented Jun 10, 2019

@maxGimeno ready for testing

@maxGimeno
Copy link
Contributor

warnings

@maxGimeno maxGimeno added Warnings For an issue about warnings, or a pull-request that fixes warnings and removed Under Testing labels Jun 12, 2019
@maxGimeno maxGimeno added Under Testing and removed Warnings For an issue about warnings, or a pull-request that fixes warnings Under Testing labels Jun 12, 2019
@maxGimeno
Copy link
Contributor

/usr/local/include/CGAL/marching_tetrahedra_3.h:56:57: error: redefinition of
'T_Vertex'
typedef typename T_Vertex_iterator::value_type T_Vertex;
^
/usr/local/include/CGAL/marching_tetrahedra_3.h:52:57: note: previous definition
is here
typedef typename T_Vertex_iterator::value_type T_Vertex;

@lrineau
Copy link
Member

lrineau commented Jun 13, 2019

The header file Skin_surface_3/include/CGAL/marching_tetrahedra_3.h still does not compile:

In file included from /home/travis/build/CGAL/cgal/Skin_surface_3/include/CGAL/mesh_skin_surface_3.h:28:
/home/travis/build/CGAL/cgal/Skin_surface_3/include/CGAL/marching_tetrahedra_3.h:144:26: error: use of undeclared identifier 'Cell_handle'
    CGAL_assertion(ch != Cell_handle());
                         ^
/home/travis/build/CGAL/cgal/Skin_surface_3/include/CGAL/marching_tetrahedra_3.h:152:28: error: use of undeclared identifier 'Cell_handle'
      CGAL_assertion(ch != Cell_handle());
                           ^
2 errors generated.

https://travis-ci.org/CGAL/cgal/jobs/544716145#L6488

@lrineau
Copy link
Member

lrineau commented Jun 13, 2019

I have fixed the compilation issues in 67e73c2.

@lrineau lrineau added this to the 5.0-beta milestone Jun 13, 2019
@maxGimeno
Copy link
Contributor

@lrineau lrineau self-assigned this Jun 17, 2019
@lrineau lrineau merged commit 67e73c2 into CGAL:master Jun 17, 2019
lrineau added a commit that referenced this pull request Jun 17, 2019
Replace NULL and Nullptr_t with nullptr and nullptr_t
@lrineau lrineau deleted the CGAL-null_ptr-GF branch June 17, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants