Header-only: consider CGAL as an imported target (if CMake>=3.11)#3922
Merged
lrineau merged 2 commits intoCGAL:releases/CGAL-4.13-branchfrom May 21, 2019
Merged
Conversation
lrineau
changed the title
|
I can confirm that this fixes OpenMVS |
|
@lrineau can u pls merge this and update the vcpkg port? many libraries depend on this patch to pass compilation tests |
Member
Author
|
@cdcseacave commented on May 15, 2019, 2:42 PM GMT+2:
I cannot before it is tested successfully by our testsuite process, on all our supported platforms. At best it could be tomorrow afternoon (Paris time). @maxGimeno can you please merge this in |
|
wonderful. I was working on a vcpkg port of openmvs and got stuck on this CGAL problem. I am also waiting for this PR to succeed :) |
Contributor
lrineau
added
rm only: ready for master
lrineau
added a commit
that referenced
this pull request
May 21, 2019
…d_target-GF Header-only: consider CGAL as an imported target (if CMake>=3.11)
lrineau
removed
Under Testing
Ready to be tested
rm only: ready for release branch
lrineau
removed
the
rm only: ready for master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix the issue cdcseacave/openMVS#425.
When CGAL is used header-only, from another project, the
CGALConfig.cmakecreates an interface library. With this change, it will be an imported interface library.Unfortunately, that feature required CMake version 3.11 or later (available only since March 28, 2018).
Release Management
Affected package(s): Installation
Issue(s) solved (if any): fix CMake Error: install(EXPORT "OpenMVSTargets" ...) includes target "MVS" which requires target "CGAL" cdcseacave/openMVS#425
License and copyright ownership: na
This PR is based on CGAL-4.13.1.